Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade base lanelet2 aware image ubuntu bionic to focal #422

Merged
merged 14 commits into from
Aug 21, 2024
Merged

Upgrade base lanelet2 aware image ubuntu bionic to focal #422

merged 14 commits into from
Aug 21, 2024

Conversation

dan-du-car
Copy link
Collaborator

@dan-du-car dan-du-car commented Aug 2, 2024 •
edited
Loading

PR Details

Description

This is a draft to demonstrate that lanelet2 aware base image built from ubuntu bionic can be upgraded to focal. https://github.com/usdot-fhwa-stol/carma-streets/actions/runs/10216841203/job/28269274374?pr=422

Related GitHub Issue

Related Jira Key

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dan-du-car dan-du-car marked this pull request as draft August 2, 2024 13:00
@dan-du-car dan-du-car changed the title Issue with ubuntu bionic Upgrade base lanelet2 aware image ubuntu bionic to focal Aug 2, 2024
@dan-du-car dan-du-car marked this pull request as ready for review August 20, 2024 18:18
@dan-du-car
Copy link
Collaborator Author

@paulbourelly999 It is ready for review.

paulbourelly999
paulbourelly999 requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@paulbourelly999 paulbourelly999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very small changes

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@paulbourelly999 paulbourelly999 merged commit 1b995a1 into develop Aug 21, 2024
2 checks passed
@paulbourelly999 paulbourelly999 deleted the cs_58_ubuntu_bionic_to_focal branch August 21, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbourelly999 paulbourelly999 paulbourelly999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-du-car @paulbourelly999