Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensor_data_sharing_service: Cannot parse timestamp in milliseconds #429

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

dan-du-car
Copy link
Collaborator

@dan-du-car dan-du-car commented Aug 29, 2024

PR Details

Description

Data sensor sharing service receives timestamp in unit of millisecond, parses and returns the result as an unsigned int data type. This data type maximum value is smaller than the timestamp value, which cause the original timestamp value to be lost.

Create another separate function to parse long data type. Parse timestamp using long data type.

Related GitHub Issue

Related Jira Key

https://usdot-carma.atlassian.net/browse/FCP-30

Motivation and Context

NA

How Has This Been Tested?

NA

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
77.78% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@dan-du-car dan-du-car merged commit 996103a into develop Aug 29, 2024
1 of 2 checks passed
@dan-du-car dan-du-car deleted the fcp-37-parse-timestamp branch August 29, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants