Update sonar-scanner.yml

[paulbourelly999]

Run on push to master and develop and on open PRs

PR Details

Description

Related GitHub Issue

Related Jira Key

Motivation and Context

How Has This Been Tested?

Types of changes

• Defect fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that cause existing functionality to change)

Checklist:

• I have added any new packages to the sonar-scanner.properties file
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

[SaikrishnaBairamoni]

I think we thought of just triggering GitHub actions as below to avoid duplicates:
Develop branch - Trigger only when PR's are merged or trigger for every change pushed into Develop directly.
Master branch - Trigger only when PR's are merged to master branch as we don't push directly.
Pull request: Triggers only when PR's are opened, closed not synchronize ?
pull_request:
types: [opened, reopened, closed]

[paulbourelly999]

Each PR merged onto develop or master should be a single commit (squash and merge) so I think triggering on each push makes sense for these branches. Then for pull request we also run to run on each push. Is what I setup correct for this.

[SaikrishnaBairamoni]

so we only build develop and master upon direct push. pull requests will triggers on each push and there will be two builds when PR are associated to develop or master. This looks good to me if we still feel like more builds are running parallel we can change it accordingly.

[paulbourelly999]

No the PR request will only run once since they are not develop or master, they are a feature branch. The reason I think PRs where running duplicate is because we had it configured to run on push for every branch including PRs and then a separate trigger for PRs. There will be no duplicates with this.