Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float fields with NaN values cause message to be discarded before writing to Influx #145

Open
adev4a opened this issue May 2, 2023 · 0 comments
Labels
anomaly anomaly is an irregularity or disproportion.

Comments

@adev4a
Copy link
Collaborator

adev4a commented May 2, 2023

Summary

During regression testing it was seen that some fields are published from carma-platform with NaN values

image

These data entries are treated as strings while the rest of the messages from this topic are parsed as floats, causing influx to reject them.
image

Commit

release/k900

Expected Behavior

NaN values should be treated as float NaN values and not strings.

Actual Behavior

NaN entries are treated as strings even though the underlying message type is a float

Steps to Reproduce the Actual Behavior

  1. Use carma_vehicle_nats_bridge for subscribe to /hardware_interface/vehicle_twist from carma-platform.
  2. Monitor messaging_server log for error writing message from topic to influx

Related Work

No response

@adev4a adev4a added bug Something isn't working anomaly anomaly is an irregularity or disproportion. labels May 2, 2023
adev4a added a commit that referenced this issue May 2, 2023
<!-- Thanks for the contribution, this is awesome. -->

# PR Details
## Description
There are a few more fields that were stored as string, but the incoming
message is of type float.

<!--- Describe your changes in detail -->

![image](https://user-images.githubusercontent.com/62157949/235765847-eb3fe9f9-1bda-44b7-b632-f5b3012bd9c2.png)

## Related Issue
#138
#145

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?
NA
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [x] Defect fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that cause existing functionality
to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have added any new packages to the sonar-scanner.properties file
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the **CONTRIBUTING** document.
[CDA Telematics Contributing
Guide](https://github.com/usdot-fhwa-stol/cda-telematics/blob/main/Contributing.md)
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
@dan-du-car dan-du-car removed the bug Something isn't working label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly anomaly is an irregularity or disproportion.
Projects
None yet
Development

No branches or pull requests

2 participants