New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data type float into string field type conflicting #144

Merged

adev4a merged 2 commits into release/k900 from hotfix_type_conflict

May 2, 2023

Collaborator

dan-du-car commented May 2, 2023 •

edited by adev4a

Loading

PR Details

Description

There are a few more fields that were stored as string, but the incoming message is of type float.

Related Issue

Motivation and Context

How Has This Been Tested?

NA

Types of changes

Defect fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that cause existing functionality to change)

Checklist:

I have added any new packages to the sonar-scanner.properties file
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
CDA Telematics Contributing Guide
I have added tests to cover my changes.
All new and existing tests passed.


          init

dan-du-car changed the title ~~init~~ Data type float into string field type conflicting

dan-du-car requested review from abey-yoseph and adev4a

May 2, 2023 19:28


          add nan

a71d39b

sonarcloud bot commented May 2, 2023

SonarCloud Quality Gate failed.

44 Bugs
1 Vulnerability
31 Security Hotspots
609 Code Smells

0.0% Coverage
1.6% Duplication

adev4a approved these changes

View reviewed changes

adev4a merged commit 52e3338 into release/k900

adev4a deleted the hotfix_type_conflict branch

May 2, 2023 21:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet