Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system time for CDASim #153

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Conversation

adev4a
Copy link
Collaborator

@adev4a adev4a commented Oct 18, 2023

PR Details

Adds environment variable to check if ros2 nats bridge is being run in simulation environment. In case it is, the ros messages are stamped to system time at time of processing in the bridge.

This is required since the the ros message headers are stamped to simulation time which may not be reasonable values to plot on the dashboard.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CDA Telematics Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

abey-yoseph
abey-yoseph previously approved these changes Oct 18, 2023
@abey-yoseph abey-yoseph merged commit 866558c into develop Oct 18, 2023
13 of 20 checks passed
@abey-yoseph abey-yoseph deleted the feature/use_system_time_cdasim branch October 18, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants