Telematic messaging server: Partial write failure field type conflict with input field payload.MessageFrame.value.PersonalSafetyMessage.id #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-du-car
changed the title
adev4a
reviewed
Nov 29, 2023
.../com/telematic/telematic_cloud_messaging/message_converters/JSON2KeyValuePairsConverter.java
Show resolved
Hide resolved
| is_ignored = true; | ||
| } | ||
| } | ||
| boolean is_processed = false; |
There was a problem hiding this comment.
Not a huge concern, but since we are processing all the fields, can we change this bool to something like is_str_cast?
There was a problem hiding this comment.
If we plan to add number_cast, we may reuse this bool
.../com/telematic/telematic_cloud_messaging/message_converters/JSON2KeyValuePairsConverter.java
Show resolved
Hide resolved
adev4a
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Collect PSM data from v2xhub, and stream it into the telematic tool. This data is eventually saved into influxDB. The influxDB creates fields and assigns data types based on the data values received. In the PSM message, payload.MessageFrame.value.PersonalSafetyMessage.id field was initially a float/number value, and influxDB created a number field type. However, payload.MessageFrame.value.PersonalSafetyMessage.id was randmonly generated 4 octet, it could populate characters in the payload.MessageFrame.value.PersonalSafetyMessage.id field beside numbers. This causes issue with influxDB when trying to save characters into a number field
Related Issue
#157
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
CDA Telematics Contributing Guide