Add rosbag processing service #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-du-car
reviewed
Feb 7, 2024
.../historical_data_processing/rosbag2_processing_service/rosbag2_processing_service/__init_.py
Outdated
Show resolved
Hide resolved
dan-du-car
reviewed
Feb 7, 2024
...tem/historical_data_processing/rosbag2_processing_service/rosbag2_processing_service/main.py
Outdated
Show resolved
Hide resolved
dan-du-car
reviewed
Feb 7, 2024
...cal_data_processing/rosbag2_processing_service/rosbag2_processing_service/service_manager.py
Outdated
Show resolved
Hide resolved
|
CI needs to be setup on this package once the implementation is complete |
adamlm
suggested changes
Feb 14, 2024
telematic_system/historical_data_processing/rosbag2_processing_service/docker/checkout.sh
Outdated
Show resolved
Hide resolved
telematic_system/historical_data_processing/rosbag2_processing_service/docker/checkout.sh
Outdated
Show resolved
Hide resolved
...tem/historical_data_processing/rosbag2_processing_service/rosbag2_processing_service/main.py
Outdated
Show resolved
Hide resolved
...al_data_processing/rosbag2_processing_service/rosbag2_processing_service/rosbag_processor.py
Outdated
Show resolved
Hide resolved
...al_data_processing/rosbag2_processing_service/rosbag2_processing_service/rosbag_processor.py
Outdated
Show resolved
Hide resolved
...al_data_processing/rosbag2_processing_service/rosbag2_processing_service/rosbag_processor.py
Outdated
Show resolved
Hide resolved
...al_data_processing/rosbag2_processing_service/rosbag2_processing_service/rosbag_processor.py
Outdated
Show resolved
Hide resolved
...al_data_processing/rosbag2_processing_service/rosbag2_processing_service/rosbag_processor.py
Outdated
Show resolved
Hide resolved
adev4a
commented
Feb 14, 2024
...cal_data_processing/rosbag2_processing_service/rosbag2_processing_service/service_manager.py
Outdated
Show resolved
Hide resolved
dan-du-car
reviewed
Feb 15, 2024
...cal_data_processing/rosbag2_processing_service/rosbag2_processing_service/service_manager.py
Outdated
Show resolved
Hide resolved
dan-du-car
reviewed
Feb 15, 2024
dan-du-car
reviewed
Feb 15, 2024
Will do this as a last step so we don't lose tracking on the comments |
adamlm
suggested changes
Feb 16, 2024
...al_data_processing/rosbag2_processing_service/rosbag2_processing_service/rosbag_processor.py
Outdated
Show resolved
Hide resolved
...al_data_processing/rosbag2_processing_service/rosbag2_processing_service/rosbag_processor.py
Outdated
Show resolved
Hide resolved
...al_data_processing/rosbag2_processing_service/rosbag2_processing_service/rosbag_processor.py
Outdated
Show resolved
Hide resolved
...al_data_processing/rosbag2_processing_service/rosbag2_processing_service/rosbag_processor.py
Outdated
Show resolved
Hide resolved
...cal_data_processing/rosbag2_processing_service/rosbag2_processing_service/service_manager.py
Outdated
Show resolved
Hide resolved
...cal_data_processing/rosbag2_processing_service/rosbag2_processing_service/service_manager.py
Outdated
Show resolved
Hide resolved
adamlm
previously approved these changes
Feb 16, 2024
dan-du-car
previously approved these changes
Feb 16, 2024
* add rosbag2_processing_service to gha * adjust python path for tests * source rosbag2 for tests and add docker build * temp add feature branch to test build * corrected sonar properties path * move source setup.bash * tweak pytest command * add pytest-env * test * min unit test * fix test * tweak path * Check Path * remove .env step * try * update tests * update unit test * test remove exprt * try pytest * Update sonar properties * update sonar propeties * update coverage file path * add unit tests --------- Co-authored-by: Anish <Anishdeva17@gmail.com>
SaikrishnaBairamoni
dismissed stale reviews from dan-du-car and adamlm
via
92f3e48
adamlm
previously approved these changes
Feb 22, 2024
adamlm
approved these changes
Feb 23, 2024
dan-du-car
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This PR adds an additional service to the telematics tool to parse and rosbags and push the deserialized data to a configured influxdb bucket. Requests to process the rosbag are received from the telematics web ui through NATS.
The service is configured with the required authentication parameters to influxdb, nats url and the directory where the rosbags will be stored.
When the service is launched in AWS EC2, the configured directory to read from will be the mounted S3 volume. On a local deployment, the parameter will be set to the directory where the web-ui is uploading the rosbag.
The service also requires connecting to a mysql database to update entries for each rosbag being processed. This functionality will be added as a separate enhancement. Currently TODO comments are added as placeholders.
Description
Related GitHub Issue
Related Jira Key
https://usdot-carma.atlassian.net/browse/WFD-503
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: