Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historical data page: Files should be upload to individual folder of S3 bucket based on user organization #180

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

dan-du-car
Copy link
Collaborator

@dan-du-car dan-du-car commented Feb 21, 2024

PR Details

Description

Files should be upload to individual folder of S3 bucket based on user organization. This can be an issue if users are not allowed to upload files with the same name from different organization.

Related GitHub Issue

#179

Related Jira Key

https://usdot-carma.atlassian.net/jira/software/c/projects/WFD/boards/38/backlog?selectedIssue=WFD-516

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

adev4a
adev4a previously approved these changes Feb 23, 2024
@dan-du-car dan-du-car changed the title WFD-516 Historical data page: Files should be upload to individual folder of S3 bucket based on user organization Feb 23, 2024
…rocess request issues (#181)

* init

* clean up

* update revision

* revise update desc func

* update

* fix file path

* add unit test

* update unit test

* address code smell
@dan-du-car dan-du-car merged commit 6e3d308 into develop Feb 23, 2024
29 of 30 checks passed
@dan-du-car dan-du-car deleted the fix_org_upload_folder branch February 23, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants