Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Historical data page: Query only list .mcap file from S3 bucket and process request issues #181

Merged
merged 9 commits into from
Feb 23, 2024
Merged

Historical data page: Query only list .mcap file from S3 bucket and process request issues #181

merged 9 commits into from
Feb 23, 2024

Conversation

dan-du-car
Copy link
Collaborator

@dan-du-car dan-du-car commented Feb 23, 2024 •
edited
Loading

PR Details

Description

  • Users can upload files if files do not exist in their own organization.
  • ROS2 rosbag table should only display a list of .mcap file even though the S3 bucket has other types of files other than .mcap files.
  • Preview table should show the browsed files that were immediately removed before.
  • Abort upload request error should be display on UI.
  • Process request is received by NATS server when uploading files to S3 bucket.

Related GitHub Issue

#178

Related Jira Key

https://usdot-carma.atlassian.net/browse/WFD-513

Motivation and Context

NA

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dan-du-car dan-du-car changed the title init WFD-513 Feb 23, 2024
@dan-du-car dan-du-car changed the title WFD-513 Historical data page: Query only list .mcap file from S3 bucket and process request issues Feb 23, 2024
@dan-du-car dan-du-car merged commit c10854e into fix_org_upload_folder Feb 23, 2024
26 of 28 checks passed
@dan-du-car dan-du-car deleted the fix_query_s3_send_request branch February 23, 2024 17:23
dan-du-car added a commit that referenced this pull request Feb 23, 2024
@dan-du-car
Historical data page: Files should be upload to individual folder of …
6e3d308 
…S3 bucket based on user organization (#180)

* init

* update local file copy dir

* user login

* update list s3 objects

* Historical data page: Query only list .mcap file from S3 bucket and process request issues  (#181)

* init

* clean up

* update revision

* revise update desc func

* update

* fix file path

* add unit test

* update unit test

* address code smell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adev4a adev4a adev4a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-du-car @adev4a