Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wfd-515 #187

Merged
merged 9 commits into from
Mar 29, 2024
Merged

wfd-515 #187

merged 9 commits into from
Mar 29, 2024

Conversation

adev4a
Copy link
Collaborator

@adev4a adev4a commented Mar 22, 2024 •
edited
Loading

PR Details

This PR fixes several issues encountered during integration testing of the historical data processing service for rosbags.

  1. Fixes call to InfluxDBClientError which was not being declared correctly.
  2. rosbag processing service tries to connect to the mysql database just once and throws an error if the database is not available. This is an issue because when bringing up the local deployment, the mysql database might start after the processing service. A max number of retries was added.
  3. rosbag processing service should try to re-establish connection to mysql if the connection fails during operation

Description

Related GitHub Issue

Related Jira Key

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adev4a adev4a marked this pull request as draft March 22, 2024 19:38
@adev4a adev4a marked this pull request as ready for review March 25, 2024 14:34
@adev4a adev4a requested a review from dan-du-car March 25, 2024 14:34
@adev4a adev4a marked this pull request as draft March 25, 2024 14:56
@adev4a adev4a self-assigned this Mar 27, 2024
@adev4a adev4a marked this pull request as ready for review March 27, 2024 17:03
@dan-du-car
Copy link
Collaborator

There are some merge conflicts.

@dan-du-car dan-du-car merged commit 615cf81 into develop Mar 29, 2024
16 checks passed
@dan-du-car dan-du-car deleted the wfd-515-integration-test-rosbag-processing branch March 29, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-du-car dan-du-car dan-du-car approved these changes

Assignees

@adev4a adev4a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adev4a @dan-du-car