Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker compose and fix build error #190

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

adev4a
Copy link
Collaborator

@adev4a adev4a commented Mar 25, 2024

PR Details

This PR fixes an import error in the rosbag2-processing-service and updates the docker-compose definition for the service required to successfully connect to NATS and mysql.

Description

Related GitHub Issue

Related Jira Key

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adev4a adev4a requested a review from dan-du-car March 25, 2024 18:44
@@ -17,6 +17,7 @@
from mcap_ros2.reader import read_ros2_messages
import re
import time
from influxdb.exceptions import InfluxDBClientError
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this import influxdb?

dan-du-car
dan-du-car previously approved these changes Mar 25, 2024
@dan-du-car dan-du-car merged commit 43f7bdd into develop Mar 25, 2024
15 of 16 checks passed
@dan-du-car dan-du-car deleted the fix-rosbag2-processing-service-deployment branch March 25, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants