Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all container and images name to be consistent #191

Merged
merged 28 commits into from
Mar 27, 2024

Conversation

dan-du-car
Copy link
Collaborator

@dan-du-car dan-du-car commented Mar 25, 2024

PR Details

Description

Update all container and images name to be consistent.
Fix the required parameter consider_namespace_packages in pytest verison 8.1.1 by downgrading it to version 8.0.2

Related GitHub Issue

NA

Related Jira Key

Motivation and Context

Integration testing

How Has This Been Tested?

Integration testing

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dan-du-car dan-du-car requested a review from adev4a March 25, 2024 20:56
source /opt/ros/foxy/setup.bash
colcon build --packages-up-to rosbag2_processing_service
apt-get -y install python3-coverage python3-pip python3-pytest python3-pytest-asyncio
pip3 install pytest==8.0.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment here about why we are using this version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@dan-du-car dan-du-car merged commit 692fc44 into develop Mar 27, 2024
16 checks passed
@dan-du-car dan-du-car deleted the docker_naming branch March 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants