New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Login Logo #203

Open

dan-du-car wants to merge 2 commits into develop from update_logo

Collaborator

dan-du-car commented Apr 9, 2024 •

edited

Loading

PR Details

Description

Update Login Logo below:
Remove password from error message

Related GitHub Issue

NA

Related Jira Key

NA

Motivation and Context

How Has This Been Tested?

Local integration test

Types of changes

Defect fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that cause existing functionality to change)

Checklist:

I have added any new packages to the sonar-scanner.properties file
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.


          update logo

92d9749

dan-du-car requested a review from adev4a

April 9, 2024 18:35


          update logo and remove password error msg

bf93045

adev4a reviewed

View reviewed changes

telematic_system/telematic_apps/web_app/client/src/pages/Login.js

+                                  data.length !== 0
+                                ) {
+                                  data.forEach((item) => {
+                                    if (

Collaborator

adev4a Apr 15, 2024

Should we be throwing an error if item.id doesn't match any org_ids?

Collaborator Author

dan-du-car Apr 15, 2024

Why would we throw error? What kind of error to throw?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet