Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create data analysis script for message drop in v2xhub Telematics plugin #231

Merged
merged 9 commits into from
Jul 2, 2024

Conversation

dan-du-car
Copy link
Collaborator

@dan-du-car dan-du-car commented Jul 1, 2024

PR Details

Description

Create data analysis script for message drop in v2xhub Telematics plugin.

  • Parse v2xhub Telematics plugin docker logs.
  • Modified get_message_drop.py script to calculate and compare the message count
    Generated message log result in csv format:

image
image

Related GitHub Issue

NA

Related Jira Key

https://usdot-carma.atlassian.net/browse/WFD-576

Motivation and Context

NA

How Has This Been Tested?

NA

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dan-du-car dan-du-car marked this pull request as draft July 1, 2024 19:33
@dan-du-car dan-du-car requested review from adev4a and tyagi86 July 1, 2024 19:33
@dan-du-car dan-du-car changed the title Create data analysis script for message drop in v2xhub Telematics plugin Create data analysis script for message drop in v2xhub Telematics plugin: Part one Jul 1, 2024
@dan-du-car dan-du-car changed the title Create data analysis script for message drop in v2xhub Telematics plugin: Part one Part 1: Create data analysis script for message drop in v2xhub Telematics plugin Jul 1, 2024
@dan-du-car dan-du-car marked this pull request as ready for review July 1, 2024 21:30
EVENT_NAME= "Event Name"
UNIT_TYPE= "Unit Type"

class LogKey(Enum):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment for why these two similar enums are needed?
Probably a note on the dependence on other logs/scripts would work

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a note on the dependence on other logs/scripts would work Could you clarify this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nit. The need for having these as two different enums is due to the logs this is reading from and the messaging server script this is comparing to.
I was suggesting adding a note here for that.

@dan-du-car dan-du-car changed the title Part 1: Create data analysis script for message drop in v2xhub Telematics plugin Create data analysis script for message drop in v2xhub Telematics plugin Jul 2, 2024

bridge_csv_exist = False
bridge_csv_regex = r'.*(Streets|Vehicle|BlueLexus|Fusion|V2xHub).*'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include Cloud here too?

@dan-du-car dan-du-car requested a review from adev4a July 2, 2024 20:31
@dan-du-car dan-du-car merged commit 53b6b4f into develop Jul 2, 2024
16 checks passed
@dan-du-car dan-du-car deleted the analyze_telematic_plugin_message_loss branch July 2, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants