Update Docker hub Workflow With Reusable actions #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adev4a
reviewed
Jul 12, 2024
dan-du-car
reviewed
Jul 12, 2024
.github/workflows/dockerhub.yml
Outdated
| id: docker-image-metadata | ||
| run: | | ||
| echo build_date=$(date -u +”%Y-%m-%dT%H:%M:%SZ”) >> $GITHUB_OUTPUT | ||
| echo vcs_ref=$(git rev-parse --short HEAD) >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
What does this vcs_ref mean?
There was a problem hiding this comment.
This git commit reference we are capturing it from actions repo usually contains a short reference to the specific git commit https://github.com/usdot-fhwa-stol/actions/blob/main/docker-build-metadata/action.yml
.github/workflows/dockerhub.yml
Outdated
| tags: usdotfhwastoldev/telematic_cloud_messaging:${{ github.ref_name }} | ||
| tags: usdotfhwastolcandidate/telematic_cloud_messaging:${{ github.ref_name }} | ||
| build-args: | | ||
| BUILD_DATE=${{ steps.docker-image-metadata.outputs.build_date }} |
There was a problem hiding this comment.
How are these build args used?
There was a problem hiding this comment.
as we are passing then during the docker build time process we can see the metadata details in the docker image layers once we build is finished so that the Docker hub image has metadata about when it was built, the commit it was built from.
dan-du-car
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Docker Hub workflow to use reusable actions from usdotfhwastol/actions repository and for consistent Docker image building and pushing.
PR Details
Description
Related GitHub Issue
Related Jira Key
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: