Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix Neon: Load default topics button has incorrect text "Save" #262

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

dan-du-car
Copy link
Collaborator

@dan-du-car dan-du-car commented Sep 17, 2024

PR Details

Description

Topic selection page: Load default topics button has incorrect text "Save". It would be confusing to the end users using this function and do not know why we have two save buttons which actually a save and load button.

This PR is to update the load default topics button text with "Load" to correctly reflect its functionality.

Related GitHub Issue

Related Jira Key

https://usdot-carma.atlassian.net/browse/WFD-600

Motivation and Context

How Has This Been Tested?

Smoke testing

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dan-du-car dan-du-car changed the title Topic selection page: Load default topics button has incorrect text "Save" Hotfix: Load default topics button has incorrect text "Save" Sep 17, 2024
@dan-du-car dan-du-car changed the title Hotfix: Load default topics button has incorrect text "Save" Hotfix Neon: Load default topics button has incorrect text "Save" Sep 17, 2024
adev4a
adev4a previously approved these changes Sep 17, 2024
@adev4a adev4a self-requested a review September 17, 2024 19:34
@adev4a
Copy link
Collaborator

adev4a commented Sep 17, 2024

Looks like the unit tests for rosbag processing service are failing due to an import error.
This was passing in an earlier PR https://github.com/usdot-fhwa-stol/cda-telematics/actions/runs/10604401313/job/29390978289

@SaikrishnaBairamoni SaikrishnaBairamoni merged commit 86308b1 into master Sep 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants