Skip to content

Commit

Permalink
Fixed unit test and added hash method for sonar scanner code smells
Browse files Browse the repository at this point in the history
  • Loading branch information
paulbourelly999 committed Jul 28, 2023
1 parent ebeb5b2 commit 8337c64
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
public class InfrastructureRegistrationMessageTest {
@Test
public void testGetterSettersConstructor() {
// Test Constructor
ArrayList<Detector> sensors = new ArrayList<>();
sensors.add(
new Detector(
Expand All @@ -43,20 +44,15 @@ public void testGetterSettersConstructor() {
8642,
CartesianPoint.xy(1, 2),
sensors);
assertEquals(message.getInfrastructureId(), "rsu_1");
assertEquals(message.getRxMessageIpAddress(), "127.0.0.1" );
assertEquals(message.getRxMessagePort(), 4567);
assertEquals(message.getTimeSyncPort(), 5678);
assertEquals(message.getSimulatedInteractionPort(), 8642);
assertEquals(message.getLocation(), CartesianPoint.xy(1,2));
assertEquals(message.getSensors(), sensors);


// Test Getter
assertEquals("rsu_1",message.getInfrastructureId());
assertEquals("127.0.0.1", message.getInfrastructureId() );
assertEquals(4567, message.getRxMessagePort());
assertEquals(5678, message.getTimeSyncPort());
assertEquals(8642, message.getSimulatedInteractionPort());
assertEquals(CartesianPoint.xy(1,2), message.getLocation());
assertEquals(sensors, message.getSensors());

}

@Test
public void testToString() {

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,27 @@ public Vector3d getAngularVelocity() {
public Size getSize() {
return size;
}

@Override
public int hashCode() {
final int prime = 31;
int result = 1;
result = prime * result + ((type == null) ? 0 : type.hashCode());
long temp;
temp = Double.doubleToLongBits(confidence);
result = prime * result + (int) (temp ^ (temp >>> 32));
result = prime * result + ((sensorId == null) ? 0 : sensorId.hashCode());
result = prime * result + ((projString == null) ? 0 : projString.hashCode());
result = prime * result + ((objectId == null) ? 0 : objectId.hashCode());
result = prime * result + ((position == null) ? 0 : position.hashCode());
result = prime * result + Arrays.hashCode(positionCovariance);
result = prime * result + ((velocity == null) ? 0 : velocity.hashCode());
result = prime * result + Arrays.hashCode(velocityCovariance);
result = prime * result + ((angularVelocity == null) ? 0 : angularVelocity.hashCode());
result = prime * result + Arrays.hashCode(angularVelocityCovariance);
result = prime * result + ((size == null) ? 0 : size.hashCode());
return result;
}

@Override
public boolean equals(Object obj) {
Expand Down

0 comments on commit 8337c64

Please sign in to comment.