From 9e6494c34594ab4d709692737c4d64eaeb6fe472 Mon Sep 17 00:00:00 2001
From: paulbourelly999 <77466294+paulbourelly999@users.noreply.github.com>
Date: Thu, 2 May 2024 14:25:49 -0400
Subject: [PATCH] Remove unused checkout.sh script and set runner explicitly
 (#217)

<!-- Thanks for the contribution, this is awesome. -->

# PR Details
## Description
Remove unused checkout script and explicitly define runner
<!--- Describe your changes in detail -->

## Related GitHub Issue

<!--- This project only accepts pull requests related to open GitHub
issues or Jira Keys -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please DO NOT name partially fixed issues, instead open an issue
specific to this fix -->
<!--- Please link to the issue here: -->

## Related Jira Key

<!-- e.g. CAR-123 -->

## Motivation and Context
Remove unused scripts
<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?
CI
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Defect fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that cause existing functionality
to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have added any new packages to the sonar-scanner.properties file
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the
[**CONTRIBUTING**](https://github.com/usdot-fhwa-stol/carma-platform/blob/develop/Contributing.md)
document.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
---
 .github/workflows/docker.yml    |  3 ++-
 .github/workflows/dockerhub.yml |  6 +++--
 docker/checkout.sh              | 44 ---------------------------------
 3 files changed, 6 insertions(+), 47 deletions(-)
 delete mode 100755 docker/checkout.sh

diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
index fe5ecef7..ba3eb807 100644
--- a/.github/workflows/docker.yml
+++ b/.github/workflows/docker.yml
@@ -2,7 +2,8 @@ name: Docker build
 on:
   pull_request:
     types: [opened, synchronize, reopened]
-
 jobs:
   docker:
     uses: usdot-fhwa-stol/actions/.github/workflows/docker.yml@main
+    with:
+      runner: ubuntu-latest-16-cores
diff --git a/.github/workflows/dockerhub.yml b/.github/workflows/dockerhub.yml
index abdd8134..09bf8bbf 100644
--- a/.github/workflows/dockerhub.yml
+++ b/.github/workflows/dockerhub.yml
@@ -2,8 +2,8 @@ name: Docker Hub build
 on:
   push:
     branches:
-      - "develop"
-      - "master"
+      - develop
+      - master
       - "release/*"
     tags:
       - "carma-system-*"
@@ -14,3 +14,5 @@ jobs:
     secrets:
       DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
       DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
+    with:
+      runner: ubuntu-latest-16-cores
diff --git a/docker/checkout.sh b/docker/checkout.sh
deleted file mode 100755
index 06391349..00000000
--- a/docker/checkout.sh
+++ /dev/null
@@ -1,44 +0,0 @@
-#!/bin/bash
-
-#  Copyright (C) 2018-2020 LEIDOS.
-# 
-#  Licensed under the Apache License, Version 2.0 (the "License"); you may not
-#  use this file except in compliance with the License. You may obtain a copy of
-#  the License at
-# 
-#  http://www.apache.org/licenses/LICENSE-2.0
-# 
-#  Unless required by applicable law or agreed to in writing, software
-#  distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-#  WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-#  License for the specific language governing permissions and limitations under
-#  the License.
-
-# CARMA packages checkout script
-# Optional argument to set the root checkout directory with no ending '/' default is '~'
-
-set -ex
-
-dir=~
-while [[ $# -gt 0 ]]; do
-      arg="$1"
-      case $arg in
-            -d|--develop)
-                  BRANCH=develop
-                  shift
-            ;;
-            -r|--root)
-                  dir=$2
-                  shift
-                  shift
-            ;;
-      esac
-done
-
-if [[ "$BRANCH" = "develop" ]]; then
-      git clone https://github.com/usdot-fhwa-stol/carma-msgs.git ~/src/carma-msgs --branch $BRANCH --depth 1
-      git clone https://github.com/usdot-fhwa-stol/carma-utils.git ~/src/carma-utils --branch $BRANCH --depth 1    
-else
-      git clone https://github.com/usdot-fhwa-stol/carma-msgs.git ${dir}/src/carma-msgs --branch carma-system-4.5.0 --depth 1
-      git clone https://github.com/usdot-fhwa-stol/carma-utils.git ${dir}/src/carma-utils --branch carma-system-4.5.0 --depth 1
-fi