Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically download CARLA tarball at build time #105

Open
codygarver opened this issue Feb 14, 2023 · 0 comments
Open

Automatically download CARLA tarball at build time #105

codygarver opened this issue Feb 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@codygarver
Copy link
Contributor

Summary

Build fails if CARLA tarball is missing, it's not set up for CI builds

Reasoning for new functionality

No response
@codygarver codygarver added the enhancement New feature or request label Feb 14, 2023
This was referenced Feb 14, 2023
Merged
Merged
kjrush added a commit that referenced this issue Feb 16, 2023
@kjrush
install.sh: conditionally download CARLA tarball (#104)
78479be 
<!-- Thanks for the contribution, this is awesome. -->

# PR Details
## Description

install.sh: conditionally download CARLA tarball

## Related Issue
#105
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Defect fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that cause existing functionality
to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have added any new packages to the sonar-scanner.properties file
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the **CONTRIBUTING** document.
[CARMA Contributing Guide](Contributing.md) 
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codygarver