Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change location of scenarios that will be deployed in docker image. #177

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kjrush
Copy link
Contributor

@kjrush kjrush commented Nov 10, 2023

Scenarios will now be deployed from co-simulation/bundle/src/assembly/scenarios rather than from sample_scenarios.zip

PR Details

Description

Changes the docker build process to automatically deploy scenario files found in src/bundle/assembly/resources/scenarios instead of relying on a pre-zipped archive of scenario files.

Related GitHub Issue

Closes #175

Related Jira Key

Motivation and Context

This makes the behavior for adding a scenario more intuitive and lets us maintain scenarios as plain files instead of a zip archive.

How Has This Been Tested?

Ran locally after building fresh docker image and confirmed newly created test scenario files were deployed at /opt/carma-simulation/scenarios in the final image.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Scenarios will now be deployed from co-simulation/bundle/src/assembly/scenarios rather than from sample_scenarios.zip
@kjrush kjrush self-assigned this Nov 10, 2023
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@paulbourelly999
Copy link
Contributor

Should this change impact VRU at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

co-simulation scenarios need to be manually extracted in the docker build
3 participants