Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARMA Ambassador forwards time to CARMA Platform #186

Merged
merged 13 commits into from
Dec 18, 2023

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Dec 13, 2023

PR Details

Description

CARMA Ambassador now forwards time sync messages to CARMA Platform. This required

  • Making the TimeSync message class a generic class available to both CARMA and Infrastructure Ambassador by placing it in carma-utils
  • Adding unit test coverage for several classes in the carma-ambassador
  • Cleaning up code smells and incorrect documentation on methods involved in change set.

Related GitHub Issue

Related Jira Key

CDAR-603

Motivation and Context

Get CARMA Platform to source ros time with CDA Sim time

How Has This Been Tested?

Unit testing

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulbourelly999 paulbourelly999 changed the title CARMA Ambassador now forwards time sync messages to platform side ada… CARMA Ambassador forwards time to CARMA Platform Dec 13, 2023
@MishkaMN MishkaMN requested review from MishkaMN and removed request for MishkaMN December 13, 2023 22:57
@paulbourelly999 paulbourelly999 marked this pull request as ready for review December 16, 2023 17:20
Copy link

sonarcloud bot commented Dec 16, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
84.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MishkaMN MishkaMN merged commit 439617e into develop Dec 18, 2023
3 checks passed
@MishkaMN MishkaMN deleted the fix/carma_platform_time_sync branch December 18, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants