Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EVC which is now in its own repository. #193

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Jan 11, 2024

PR Details

Description

EVC Sumo has been removed from the CDASim repository and moved to its own repository (https://github.com/usdot-fhwa-stol/evc-sumo)

Related GitHub Issue

Related Jira Key

CDAR-675

Motivation and Context

Improve modularity and reduce coupling

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulbourelly999 paulbourelly999 marked this pull request as ready for review January 11, 2024 19:00
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MishkaMN
Copy link
Contributor

MishkaMN commented Jan 11, 2024

I updated the small documentation we have for this in the install steps
https://usdot-carma.atlassian.net/wiki/spaces/CRMSIM/pages/2526937089/Setup+Instructions+Documentation+CARMA-Streets+Integration

@MishkaMN MishkaMN merged commit 48bff23 into develop Jan 11, 2024
3 checks passed
@MishkaMN MishkaMN deleted the fix/remove_evc branch January 11, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants