Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDAR-756: Carla Ambassador correct detection timestamp #197

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Feb 2, 2024

PR Details

Description

This PR updates incoming CARLA detections, which have Carla time stamps, to have cdasim time stamps since all components in this system use cdasim time. This fix is necessary because prior to establishing connection to cdasim, carla spins for some time, creating a random static time offset between carla game-time and cda sim simulation time.

NOTE: This PR also includes necessary fixes to use java 17 for sonar scanner CI process

Related GitHub Issue

Related Jira Key

CDAR-756

Motivation and Context

Gives detection data a simulation time step that should be accurate to sim time.

How Has This Been Tested?

CDASim deployment

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulbourelly999 paulbourelly999 marked this pull request as ready for review February 6, 2024 07:10
Copy link

sonarcloud bot commented Feb 6, 2024

@paulbourelly999 paulbourelly999 merged commit 8d50ef9 into develop Feb 6, 2024
3 checks passed
@paulbourelly999 paulbourelly999 deleted the cdar-756-correct-carla-detection-timestamp branch February 6, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants