CARMA Cloud ambassador integration #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../src/main/java/org/eclipse/mosaic/fed/carmacloud/ambassador/CarmaCloudMessageAmbassador.java
Show resolved
Hide resolved
| */ | ||
| public class CarmaCloudRegistrationReceiver implements Runnable | ||
| { | ||
| private static final int LISTEN_PORT = 1617; // which port for CARMA Cloud? |
There was a problem hiding this comment.
Is this comment still relevant?
...d/src/main/java/org/eclipse/mosaic/fed/carmacloud/configuration/CarmaCloudConfiguration.java
Show resolved
Hide resolved
| private StringBuilder messageBuf = new StringBuilder(); | ||
| private HttpServer oSrvr; | ||
|
|
||
| class TimeSyncHandler implements HttpHandler { |
There was a problem hiding this comment.
Nit: We should probably leave a comment for the unit test to remove the HTTP Server and use mocks instead. Using an actual HttpServer for a unit test makes the unit test harder to maintain and likely causes the unit test to require more resources (time and processing). Not high priority right now but a TODO comment will help us track this technical debt.
paulbourelly999
requested changes
May 2, 2024
paulbourelly999
requested changes
May 3, 2024
|
paulbourelly999
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This PR primarily focuses on merging a branch into develop, which encompasses the integration testing of CARMA Cloud with CDASim. The purpose of this integration test was to assess the communication between CARMA Cloud and CDASim, ensuring that:
All components operate correctly within CDASim without encountering any significant problems.
CARMA Cloud successfully registers with Ambassador.
CARMA Cloud receives and processes time synchronization messages.
Related GitHub Issue
Related Jira Key
CXC-10
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: