Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug flag requirement for time sync script log for sumo #210

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

MishkaMN
Copy link
Contributor

@MishkaMN MishkaMN commented Mar 27, 2024

PR Details

Description

Previous PR here #205 merged a log statement line that the time sync script relies on (usdot-fhwa-stol/carma-analytics-fotda#43).

  • However, it had a typo, which this PR fixes.
  • This PR also removes the debug log requirement for this line change because one simulation run log from this same class could easily be 500MB. Time sync script is working too much to parse every single line and is having adverse effect.
    Since the line is just a log statement, it is safe to leave it in there without DEBUG option and its size goes up to 500kb or so

image

vs

image

Related GitHub Issue

#209

Related Jira Key

https://usdot-carma.atlassian.net/browse/CDAR-662
https://usdot-carma.atlassian.net/browse/CDAR-774

Motivation and Context

VRU verification testing

How Has This Been Tested?

sim pc 1

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

sonarcloud bot commented Mar 27, 2024

@MishkaMN MishkaMN merged commit a190c2a into release/lavida Mar 27, 2024
2 of 3 checks passed
@MishkaMN MishkaMN deleted the feature/time-sync-script-fix-for-sumo branch March 27, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants