Common functionality for SUMO CARMA Messenger Vehicle Plugin #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjrush
reviewed
Sep 29, 2024
| for msg_veh_id in msg_veh_ids: | ||
|
|
||
| if msg_veh_id not in sumo_veh_ids and \ | ||
| msger_veh_cfg.get_veh_state(msg_veh_id) == 0 and \ |
There was a problem hiding this comment.
Having some sort of constant for this 0 would be good. What state is that supposed to represent?
| sumo_connector.set_veh_speed(msg_veh_id, msger_veh_cfg.get_veh_speed(msg_veh_id)) | ||
| sumo_connector.set_veh_lcm(msg_veh_id, msger_veh_cfg.get_veh_lcm(msg_veh_id)) | ||
| sumo_connector.set_veh_type(msg_veh_id, msger_veh_cfg.get_veh_cfm(msg_veh_id)) | ||
| msger_veh_cfg.set_veh_state(msg_veh_id, 1) |
There was a problem hiding this comment.
Similar comment here re: state.
There was a problem hiding this comment.
Might be cleanest to define some sort of enum with these numerical values for states, and then reference that enum instead of the raw integer literal values.
| "lcm": veh["lcm"], | ||
| "cfm": veh["cfm"] | ||
| } | ||
| self._veh_state_dict[veh_id] = 0 |
There was a problem hiding this comment.
Would be good to define the states as an Enum type, and then use the state names instead of int literals.
|
kjrush
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This PR introduces the implementation of the CARMA-messenger vehicle plugin for CDASim, aligning with the High-level Design for Freight ERV functionality documentation
Related GitHub Issue
Related Jira Key
CXC-87
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: