Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflows #36

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Add CI workflows #36

merged 4 commits into from
Sep 15, 2023

Conversation

SaikrishnaBairamoni
Copy link
Contributor

No description provided.

Copy link
Collaborator

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an open CDOT PR (CDOT-CV#14) that involves switching out ubuntu as the base image for the ACM with alpine. These changes look good for the current base image, but once these changes are in USDOT develop this will need to be modified.

Comment on lines +8 to +10
runs-on: ubuntu-latest
container:
image: ubuntu:jammy-20230126
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some incoming CDOT changes that replace ubuntu with alpine as the base image for the ACM. This will need to be modified once those changes have been merged into USDOT develop.

Comment on lines +20 to +56
- name: Install necessary dependencies
run: |
apt update
apt-get -y install sudo wget curl gnupg lsb-release gcovr unzip gcc-multilib libasan*
sudo apt-get -y install software-properties-common
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key add -
sudo add-apt-repository -y "deb [arch=amd64] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable"
sudo curl -L "https://github.com/docker/compose/releases/download/1.24.0/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
chmod +x /usr/local/bin/docker-compose
sudo apt-get -y update
sudo apt-get -y install docker-ce
working-directory: ${{ env.working-directory }}

- name: Install g++ and related dependencies
run: |
sudo apt-get -y install build-essential
sudo apt -y install cmake g++ libprotobuf-dev protobuf-compiler
sudo apt -y install apt-transport-https ca-certificates curl software-properties-common
export CXX="g++"
sudo apt install -y gcc-12 g++-12
sudo apt -y install libpng-dev libgraphicsmagick1-dev libcairo2-dev
working-directory: ${{ env.working-directory }}

- name: Install librdkafka
run: |
sudo apt-get -y update && sudo apt-get -y upgrade
sudo apt-get -y install automake flex bison
sudo apt-get -y install build-essential
sudo apt -y install cmake g++ libprotobuf-dev protobuf-compiler
sudo apt-get install autotools-dev
sudo apt -y install apt-transport-https ca-certificates curl software-properties-common
git clone --depth 1 https://github.com/confluentinc/librdkafka.git librdkafka
cd librdkafka
cmake -H. -B_cmake_build
cmake --build _cmake_build
cmake --build _cmake_build --target install
working-directory: ${{ env.working-directory }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All references to apt will need to be replaced with apk-equivalent statements when the incoming CDOT alpine-image changes are merged into USDOT develop.

Comment on lines +22 to +28
# build asn1_codec
mkdir build
cd build
cmake ..
cmake --build .
make
ctest --output-on-failure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this script been tested and verified to be working as expected?

Copy link
Collaborator

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Alpine base image switch probably won't be part of the Q3 release, so it seems like a good idea to merge this now. We can deal with the package manager modifications at a later time.

Copy link

@TonyEnglish TonyEnglish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Alpine image work will wait until the next release for Q4, this is good to merge.

@SaikrishnaBairamoni SaikrishnaBairamoni merged commit 188f41a into develop Sep 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants