Improve readme instructions #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewjj
approved these changes
Jan 31, 2024
John-Wiens
approved these changes
Jan 31, 2024
|
@John-Wiens good question, it was not intentional. This detached head points to a "hotfix/1.5.1", which gives me pause. I'm a little tempted to revert the change back to the previous detached head, but would that cause bigger problems for the PRs that were already merged? From my testing so far I don't have reason to believe the change breaks our workflow, but my environment is not yet 100% running so there could be something I missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of 3 matching pull requests aim to clarify a few points in the Readme installation instructions that slowed me down when I was installing the environment for the first time. I don't necessarily have a big-picture in mind around which components might or might not be designed to run independently, so please correct me if any of my additions are missing important context.