Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Expiration Date meta data for tracking in the SDX #532

Merged
merged 11 commits into from
Feb 5, 2024

Conversation

Ryan-Roan
Copy link
Contributor

@Ryan-Roan Ryan-Roan commented Jan 29, 2024

PR Details

Addition of Expiration Date meta data for tracking in the SDX.

PR Detail Note: There are changes relevant to this PR in a separate PR on the jpo-sdw-depositor repository. It would be prudent to merge these changes in together. usdot-jpo-ode/jpo-sdw-depositor#33

Additional field expireDate added to the SituationDataWarehouse object. Alterations to EncodedDataRouter to utilize new information and pass it along to consumers of the SDX. Specifically ASN1CommandManager.depositToSdw.

Related Issue

Currently no known issue.

Motivation and Context

ASN1 formatting only allows for TIM data objects to have a duration of a maximum ~22 days. DOT facilities have a need to represent TIM advisories for a longer period than can be managed through the encoding alone. As DOT facilities often know there is an extended expiration, we would like to provide the ability to store the correct expiration date, while maintaining the correct encoding practices of ASN1 for all encodable information.

How Has This Been Tested?

Ran the TIM_Message_Testing_Files suite both with and without the changes to the Command manager to show matching results. Ran the existing Maven tests to verify depositToSdw test passes as expected. Added additional Maven test passing json object to verify form.

Testing environment was VS Code running provided .devcontainer. Utilizing a modified version of the SDWD with correlating changes.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    ODE Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dan-du-car dan-du-car merged commit 0de0068 into usdot-jpo-ode:develop Feb 5, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants