-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit Tests, Artifact Publishing & Updated Documentation #33
Conversation
…natureController class
…eController class
…atureController class
…ssage to external service using certificates
…service using certificates
Added unit tests to the project
GitHub actions artifact publishing
…uracy Revised Documentation for Accuracy
…ease-notes Version Change & Release Notes (2024 Q3 Release)
@@ -0,0 +1,31 @@ | |||
name: Publish Java Package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will be the approx. artifact size and where we are using this ? As our ODE GitHub org is on free plan we have artifact storage limit of 500mb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project's JAR file is about 57 MB in size. It is not currently being used, but it is for potential future use. It may be possible to reduce the size of the JAR file in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmccoystephenson seems like for Maven packages and other packages like npm, docker, etc storage limit will be not applied for public repo's. so I think we should be good to use artifacts. However for any private repo's this limits will apply. We have a backlog item for supporting GitHub artifacts setup in future release. Thanks!
Unit Tests
Problem
No unit tests were previously implemented.
Solution
Unit tests have now been added.
New Classes
To improve testability, the following classes have been introduced to encapsulate specific operations:
The Message class has also been moved to its own file.
Typo Correction
The typo "certficates" has been corrected to "certificates" throughout the project.
Testing
All unit tests pass, and the signing functionality has been confirmed to work.
Artifact Publishing
A GitHub Action has been added to publish Java artifacts to GitHub's hosted Maven Central.
Updated Documentation
Problem
The README was outdated and unclear.
Solution
The README has been updated for accuracy and clarity.