Recommend UUIDs for identifiers and add "name" to RoadEventCoreDetails #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-d-b
added
Refactor
mollybehan
approved these changes
Mar 23, 2022
mark-mockett
approved these changes
May 25, 2022
examples/RoadRestrictionFeed/bridge_height_restriction_linestring_example.geojson
Outdated
Show resolved
Hide resolved
Updating the added value in the core details to use the new name field instead of id.
Updated Bridge3 UUID so it is not duplicated from Bridge2
sknick-iastate
approved these changes
Jul 7, 2022
jlarsonOmahaNE
approved these changes
Jul 13, 2022
mark-mockett
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #207. Specifically, the following changes are proposed:
idproperty and the FeedDataSourcedata_source_idproperty.nameproperty to the RoadEventCoreDetailsnameproperty.