Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up samples plots #2

Open
bennn opened this issue Sep 6, 2017 · 1 comment
Open

Speed up samples plots #2

bennn opened this issue Sep 6, 2017 · 1 comment

Comments

@bennn
Copy link
Member

bennn commented Sep 6, 2017

Rendering a samples-plot is slow right now, because it uses non-optimized configuration counting.

There's a deep problem: it's hard to get the "total" number of configurations.

  • For exhaustive data, the total is "all configurations"
  • For approximate data, the total is the sample size

Probably need to build a hook to override.

NOTE: a bad way to override would be:

  • add a num-configurations field to the performance-info struct
  • set it to the sample size, sometimes
@bennn
Copy link
Member Author

bennn commented Aug 31, 2018

Please fix, it's annoying to work around this using caches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant