Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for account identity event consumers #616

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Add configuration for account identity event consumers #616

merged 3 commits into from
Oct 9, 2024

Conversation

martskins
Copy link
Contributor

No description provided.

@martskins martskins requested a review from a team as a code owner October 9, 2024 14:10
@uw-infra
Copy link

uw-infra commented Oct 9, 2024 •
edited
Loading

Terraform plan output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-cbc
Path: dev-aws/kafka-shared-msk/cbc
Commit ID: 903d4935b84dc852c0218d77af1273828f06cb60
✅ Run Status: Ok, Run Summary: Plan: 4 to add, 0 to change, 0 to destroy. 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.cbc_account_events_relay.kafka_acl.group_acl["account-identity.cbc-fraud-detection-consumer-v1"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-account-events-relay-v2"
      + id                           = (known after apply)
      + resource_name                = "account-identity.cbc-fraud-detection-consumer-v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.cbc_account_events_relay.kafka_acl.topic_acl["account-identity.public.account.events"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-account-events-relay-v2"
      + id                           = (known after apply)
      + resource_name                = "account-identity.public.account.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.cbc_fraud_detection_consumer.kafka_acl.group_acl["account-identity.cbc-fraud-detection-consumer-v1"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-fraud-detection-consumer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.cbc-fraud-detection-consumer-v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.cbc_fraud_detection_consumer.kafka_acl.topic_acl["account-identity.public.account.events"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-fraud-detection-consumer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.public.account.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 4 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/cbc as comment.

@uw-infra
Copy link

uw-infra commented Oct 9, 2024 •
edited
Loading

Terraform plan output for

Cluster: prod-aws
Module: pubsub/kafka-shared-msk-cbc
Path: prod-aws/kafka-shared-msk/cbc
Commit ID: 903d4935b84dc852c0218d77af1273828f06cb60
✅ Run Status: Ok, Run Summary: Plan: 5 to add, 0 to change, 0 to destroy. 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.cbc_account_events_relay.kafka_acl.group_acl["account-identity.cbc-fraud-detection-consumer-v1"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-account-events-relay-v2"
      + id                           = (known after apply)
      + resource_name                = "account-identity.cbc-fraud-detection-consumer-v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.cbc_account_events_relay.kafka_acl.topic_acl["account-identity.public.account.events"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-account-events-relay-v2"
      + id                           = (known after apply)
      + resource_name                = "account-identity.public.account.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.cbc_account_events_relay.kafka_quota.quota will be created
  + resource "kafka_quota" "quota" {
      + config      = {
          + "consumer_byte_rate" = 5242880
          + "producer_byte_rate" = 5242880
          + "request_percentage" = 100
        }
      + entity_name = "CN=cbc/cbc-account-events-relay-v2"
      + entity_type = "user"
      + id          = (known after apply)
    }

  # module.cbc_fraud_detection_consumer.kafka_acl.group_acl["account-identity.cbc-fraud-detection-consumer-v1"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-fraud-detection-consumer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.cbc-fraud-detection-consumer-v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.cbc_fraud_detection_consumer.kafka_acl.topic_acl["account-identity.cbc-fraud-detection-consumer-v1"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-fraud-detection-consumer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.cbc-fraud-detection-consumer-v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 5 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan prod-aws/kafka-shared-msk/cbc as comment.

LukeG07
LukeG07 reviewed Oct 9, 2024
View reviewed changes
prod-aws/kafka-shared-msk/cbc/cbc.tf Outdated Show resolved Hide resolved
dev-aws/kafka-shared-msk/cbc/cbc.tf Outdated Show resolved Hide resolved
@Nesze Nesze mentioned this pull request Oct 9, 2024
Closed
@martskins @LukeG07
Update prod-aws/kafka-shared-msk/cbc/cbc.tf
9bb5fb5 
Co-authored-by: Luke Gibbard <52913435+LukeG07@users.noreply.github.com>
@uw-infra
Copy link

uw-infra commented Oct 9, 2024 •
edited
Loading

Terraform plan output for

Cluster: prod-aws
Module: pubsub/kafka-shared-msk-cbc
Path: prod-aws/kafka-shared-msk/cbc
Commit ID: 9bb5fb5d7c5d50e9ee6e3ec62c77bc72191eb667
✅ Run Status: Ok, Run Summary: Plan: 5 to add, 0 to change, 0 to destroy. 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.cbc_account_events_relay.kafka_acl.group_acl["account-identity.cbc-account-events-relay-v2"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-account-events-relay-v2"
      + id                           = (known after apply)
      + resource_name                = "account-identity.cbc-account-events-relay-v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.cbc_account_events_relay.kafka_acl.topic_acl["account-identity.public.account.events"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-account-events-relay-v2"
      + id                           = (known after apply)
      + resource_name                = "account-identity.public.account.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.cbc_account_events_relay.kafka_quota.quota will be created
  + resource "kafka_quota" "quota" {
      + config      = {
          + "consumer_byte_rate" = 5242880
          + "producer_byte_rate" = 5242880
          + "request_percentage" = 100
        }
      + entity_name = "CN=cbc/cbc-account-events-relay-v2"
      + entity_type = "user"
      + id          = (known after apply)
    }

  # module.cbc_fraud_detection_consumer.kafka_acl.group_acl["account-identity.cbc-fraud-detection-consumer-v1"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-fraud-detection-consumer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.cbc-fraud-detection-consumer-v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.cbc_fraud_detection_consumer.kafka_acl.topic_acl["account-identity.cbc-fraud-detection-consumer-v1"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-fraud-detection-consumer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.cbc-fraud-detection-consumer-v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 5 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan prod-aws/kafka-shared-msk/cbc as comment.

@martskins @LukeG07
Update dev-aws/kafka-shared-msk/cbc/cbc.tf
864ad78 
Co-authored-by: Luke Gibbard <52913435+LukeG07@users.noreply.github.com>
@uw-infra
Copy link

uw-infra commented Oct 9, 2024 •
edited
Loading

Terraform plan output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-cbc
Path: dev-aws/kafka-shared-msk/cbc
Commit ID: 864ad7835bd27f57a0641a4a8acc0c4a62ebaf65
✅ Run Status: Ok, Run Summary: Plan: 4 to add, 0 to change, 0 to destroy. 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.cbc_account_events_relay.kafka_acl.group_acl["account-identity.cbc-account-events-relay-v2"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-account-events-relay-v2"
      + id                           = (known after apply)
      + resource_name                = "account-identity.cbc-account-events-relay-v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.cbc_account_events_relay.kafka_acl.topic_acl["account-identity.public.account.events"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-account-events-relay-v2"
      + id                           = (known after apply)
      + resource_name                = "account-identity.public.account.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.cbc_fraud_detection_consumer.kafka_acl.group_acl["account-identity.cbc-fraud-detection-consumer-v1"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-fraud-detection-consumer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.cbc-fraud-detection-consumer-v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.cbc_fraud_detection_consumer.kafka_acl.topic_acl["account-identity.public.account.events"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-fraud-detection-consumer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.public.account.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 4 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/cbc as comment.

@martskins martskins merged commit 85ed641 into main Oct 9, 2024
2 checks passed
@martskins martskins deleted the account-identity-consumers branch October 9, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeG07 LukeG07 LukeG07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martskins @uw-infra @LukeG07