Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix account topic names #618

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix account topic names #618

merged 1 commit into from
Oct 9, 2024

Conversation

LukeG07
Copy link
Contributor

@LukeG07 LukeG07 commented Oct 9, 2024

No description provided.

@LukeG07 LukeG07 requested a review from a team as a code owner October 9, 2024 15:42
@uw-infra
Copy link

uw-infra commented Oct 9, 2024

Terraform plan output for

Cluster: prod-aws
Module: pubsub/kafka-shared-msk-cbc
Path: prod-aws/kafka-shared-msk/cbc
Commit ID: a4bea0393c89994658a03b71c0f422e2a6dc7b23
✅ Run Status: Ok, Run Summary: Plan: 2 to add, 0 to change, 2 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # module.cbc_account_events_relay.kafka_acl.topic_acl["account-identity.legacy.account.events"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-account-events-relay-v2"
      + id                           = (known after apply)
      + resource_name                = "account-identity.legacy.account.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.cbc_account_events_relay.kafka_acl.topic_acl["account-identity.public.account.events"] will be destroyed
  # (because key ["account-identity.public.account.events"] is not in for_each map)
  - resource "kafka_acl" "topic_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Read" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=cbc/cbc-account-events-relay-v2" -> null
      - id                           = "User:CN=cbc/cbc-account-events-relay-v2|*|Read|Allow|Topic|account-identity.public.account.events|Literal" -> null
      - resource_name                = "account-identity.public.account.events" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Topic" -> null
    }

  # module.cbc_fraud_detection_consumer.kafka_acl.topic_acl["account-identity.cbc-fraud-detection-consumer-v1"] will be destroyed
  # (because key ["account-identity.cbc-fraud-detection-consumer-v1"] is not in for_each map)
  - resource "kafka_acl" "topic_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Read" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=cbc/cbc-fraud-detection-consumer" -> null
      - id                           = "User:CN=cbc/cbc-fraud-detection-consumer|*|Read|Allow|Topic|account-identity.cbc-fraud-detection-consumer-v1|Literal" -> null
      - resource_name                = "account-identity.cbc-fraud-detection-consumer-v1" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Topic" -> null
    }

  # module.cbc_fraud_detection_consumer.kafka_acl.topic_acl["account-identity.public.account.events"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=cbc/cbc-fraud-detection-consumer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.public.account.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 2 to add, 0 to change, 2 to destroy.

To manually trigger plan again please post @terraform-applier plan prod-aws/kafka-shared-msk/cbc as comment.

@LukeG07 LukeG07 merged commit 2c15c1f into main Oct 9, 2024
1 check passed
@LukeG07 LukeG07 deleted the fix-topic-names branch October 9, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants