Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix differ sink #621

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix differ sink #621

merged 1 commit into from
Oct 11, 2024

Conversation

abramin
Copy link
Contributor

@abramin abramin commented Oct 11, 2024

No description provided.

@abramin abramin requested a review from a team as a code owner October 11, 2024 09:31
@uw-infra
Copy link

uw-infra commented Oct 11, 2024

Terraform plan output for

Cluster: prod-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: prod-aws/kafka-shared-msk/account-identity
Commit ID: 6d96334bbf50db5117c35e732d9a5a50f0d8c162
✅ Run Status: Ok, Run Summary: Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # module.account_identity_legacy_account_differ.kafka_acl.producer_acl["account-identity.legacy.account.changelog.events"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/legacy_account_differ"
      + id                           = (known after apply)
      + resource_name                = "account-identity.legacy.account.changelog.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.account_identity_legacy_account_differ.kafka_acl.topic_acl["account-identity.legacy.account.changelog.events"] will be destroyed
  # (because key ["account-identity.legacy.account.changelog.events"] is not in for_each map)
  - resource "kafka_acl" "topic_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Read" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=account-platform/legacy_account_differ" -> null
      - id                           = "User:CN=account-platform/legacy_account_differ|*|Read|Allow|Topic|account-identity.legacy.account.changelog.events|Literal" -> null
      - resource_name                = "account-identity.legacy.account.changelog.events" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Topic" -> null
    }

Plan: 1 to add, 0 to change, 1 to destroy.

To manually trigger plan again please post @terraform-applier plan prod-aws/kafka-shared-msk/account-identity as comment.

@abramin abramin self-assigned this Oct 11, 2024
@abramin abramin merged commit da7595f into main Oct 11, 2024
2 checks passed
@abramin abramin deleted the differ-sink branch October 11, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants