Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coffee history to ES indexer allow #745

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Add coffee history to ES indexer allow #745

merged 1 commit into from
Jan 3, 2025

Conversation

cdempsie
Copy link
Contributor

@cdempsie cdempsie commented Jan 3, 2025

No description provided.

@cdempsie cdempsie requested a review from a team as a code owner January 3, 2025 13:44
@uw-infra
Copy link

uw-infra commented Jan 3, 2025

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-customer-support
Path: dev-aws/kafka-shared-msk/customer-support
Commit ID: 6055d84221cbe17bad9a5450112ab7ea7f646705
✅ Run Status: Ok, Run Summary: Plan: 1 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.es_topic_indexer.kafka_acl.topic_acl["customer-support.coffee_account_history_v1"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=crm/msk-topic-indexer"
      + id                           = (known after apply)
      + resource_name                = "customer-support.coffee_account_history_v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/customer-support as comment.

@cdempsie cdempsie merged commit 8a38435 into main Jan 3, 2025
2 checks passed
@cdempsie cdempsie deleted the cdempsie-patch-1 branch January 3, 2025 13:48
@uw-infra
Copy link

uw-infra commented Jan 3, 2025

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-customer-support
Path: dev-aws/kafka-shared-msk/customer-support
Commit ID: 8a38435b71a696459ef67f631bbff8a3d99ab718
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 1 added, 0 changed, 0 destroyed
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.es_topic_indexer.kafka_acl.topic_acl["customer-support.coffee_account_history_v1"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=crm/msk-topic-indexer"
      + id                           = (known after apply)
      + resource_name                = "customer-support.coffee_account_history_v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 1 to add, 0 to change, 0 to destroy.
module.es_topic_indexer.kafka_acl.topic_acl["customer-support.coffee_account_history_v1"]: Creating...
module.es_topic_indexer.kafka_acl.topic_acl["customer-support.coffee_account_history_v1"]: Creation complete after 1s [id=User:CN=crm/msk-topic-indexer|*|Read|Allow|Topic|customer-support.coffee_account_history_v1|Literal]

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 12, in provider "kafka":
  12: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `client_cert` instead.

(and one more similar warning elsewhere)

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/customer-support as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants