Do not use atomic to lock when not needed

utilitywarehouse · Sep 18, 2024 · d1599a8 · d1599a8
1 parent 75ec992
commit d1599a8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/xds/snapshotter.go b/xds/snapshotter.go
@@ -193,7 +193,7 @@ func (s *Snapshotter) SnapServices(serviceStore XdsServiceStore) error {
 	}
 	s.snapNodesMu.Lock()
 	defer s.snapNodesMu.Unlock()
-	atomic.AddInt32(&s.serviceSnapVersion, 1)
+	s.serviceSnapVersion += int32(1)
 	resources := map[string][]types.Resource{
 		resource.ClusterType:  cls,
 		resource.ListenerType: lsnr,
@@ -247,7 +247,7 @@ func (s *Snapshotter) SnapEndpoints(endpointStore XdsEndpointStore) error {
 	}
 	s.snapNodesMu.Lock()
 	defer s.snapNodesMu.Unlock()
-	atomic.AddInt32(&s.endpointsSnapVersion, 1)
+	s.endpointsSnapVersion += int32(1)
 	resources := map[string][]types.Resource{
 		resource.EndpointType: eds,
 	}