Handle scenarios where EndpointSlices are missing Zone #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw a case where the xds servers were spinning because an EndpointSlice/Address did not specify a Zone. We should still be able to serve those endpoints to clients and create an alert to manually check things. Kube-controller-manager is responsible for populating the zone in EndpointSlices. We set the value to "none". This will not affect existing routing algorithms but should be taken into account if we implement zone specific routing strategies in the future.
hectorhuertas
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw a case where the xds servers were spinning because an EndpointSlice/Address did not specify a Zone. We should still be able to serve those endpoints to clients and create an alert to manually check things.
Kube-controller-manager is responsible for populating the zone in EndpointSlices.
We set the value to "none". This will not affect existing routing algorithms but should be taken into account if we implement zone specific routing strategies in the future.