Reduce ContainerRestarting alert noise #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffilippopoulos
approved these changes
Oct 10, 2023
Once fired, leave it firing for 10m. That should help with crashloops where the alert keeps getting resolved and firing again.
hectorhuertas
force-pushed
the
reduce-flakyness
branch
from
d5a453d
to
26cdc3a
Compare
|
thanos-io/thanos#6165 - is this in Thanos? |
|
good point, I'll check |
|
You are correct, it is not implemented in thanos yet, it gets silently ignored. Leaving it there since it's not breaking the alert and it will eventually work once we update to a thanos version that implements it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once fired, leave it firing for 10m. That should help with crashloops where the alert keeps getting resolved and firing again.