RFC: tiered missing replicas alerts #61
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: Using tiering in stock alerts.
This is a proposal and a request for comments on including tier information in stock alerts.
👍
All alerts are important, and the goal of the separation by tier is to allow us to provide better escalation policy for business hours and out of hours support depending on the impact.
👎
There is a drawback here with each alert
Statefulset|DeploymentMissingXReplicas
being replaced by 5 separate (in reality) copies:TierUnknown|1|2|3|4DeploymentMissingXReplicas
alerts but that's what makes them useful downstream.Notes
Unknown Tier
alerts should be treated asTier 1
alerts.keep_firing_for
- this is meant to mitigate flappy alerts in situations when deployment/sts comes up for a short period of time and fails quicklyDeployment
andStatefulset
to provide working examples currently only those have annotations mentioned here whitelisted. This can be easily extended toDaemonsets
.Tier summary