Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to git-mirror to support different revision / module #178

Merged
merged 13 commits into from
Mar 21, 2024

Conversation

asiyani
Copy link
Contributor

@asiyani asiyani commented Mar 19, 2024

This PR contains breaking changes....
CRD now accepts both repoName and repoURL as optional field
Controller in this PR will use repoURL instead of repoName to resolve repository added by admins.

Following steps should be followed to minimise disruption

  1. Deploy New Version of CRD only so that we can add repoURL to modules
  2. Update ALL modules and add repoURL field keeping old repoName as it is.
  3. deploy new version of controller
  4. once new version of controller is deployed it will start using repoURL instead of repoName field.
  5. we can now remove repoName field from the CRD. as that field will be deleted from next version of CRD

@asiyani asiyani merged commit 2ac8365 into master Mar 21, 2024
7 checks passed
@asiyani asiyani deleted the as-git-mirror branch March 21, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants