Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file wont parse #34

Closed
wants to merge 1 commit into from
Closed

Conversation

orangewolf
Copy link
Contributor

the file fails when we try to upload it to AF. I'm not sure which change is the one that fixes it but one of these edits did the trick. I don't recommend pulling this in as is, I'm hoping Mark can spot the trouble field and dont want to loose track of it

the file fails when we try to upload it to AF. I'm not sure which change is the one that fixes it but one of these edits did the trick.
@markpbaggett
Copy link
Contributor

@orangewolf I'm not sure that I'm following, but I think you're saying that the current version doesn't work, but one of the changes you've made here fixes it.

I have a question. Most of your changes look fine, but you have a thing here that is making our linter mad because you're setting mappings twice: once as an empty object and once as an object with several keys. Since yaml isn't ordered, I'm not sure how the implementation of yaml in Ruby is reading in your change and if it's reading the first or second mapping. When you opened this pr a few weeks ago, I emptied the empty one. Should the empty one be included here but the one on line 3487 be removed?

@orangewolf
Copy link
Contributor Author

found it. see the other PR

@orangewolf orangewolf closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants