Godot 4.0 adaption (Windows + MacOS)

[bitbrain]

Goal

This pull request aims to make this addon compatible with Godot 4.0+, relates to #121

Todo list

• make C++ code compile with new Godot 4.x headers by adjusting the syntax
• make gdscript Godot 4 compatible
• replicate signals
• ensure argument names are configured -> Node documentation example paddy-exe/GDExtensionSummator#8
• configure .svg icon for FmodEventEmitter
• update build pipeline to build against Godot 4 (done by @2shady4u )
• ensure GUT works with Godot 4 -> Godot 4.0 adaption bitwes/Gut#378
• Ensure SConstruct file works correctly
• Successfully build .gdextension file
• Port demo project to Godot 4 - use the new command-line project converter for this
• rewrite the build and release pipelines: 4.x branch should build against Godot 4 while the main branch should build against Godot 3 https://github.com/utopia-rise/fmod-gdnative/blob/master/.github/workflows/all_builds.yml#L15
• port FmodEventEmitter as C++ type to be natively available within Godot
• remove Fmod.gd script
• will be done in seperate PR: re-enable Gut as part of tests @2shady4u
• will be done in seperate PR: change README.md docs to explain how to build/contribute
• will be done in seperate PR: apply Add default callback setting #136 once merged
• apply Use custom clang format #137 once merged

Currently known issues

• 🐛 timeline beat signals do not seem to work quite @CedNaru
• 🐛 missing FMOD_ constants @bitbrain
• 🐛 iOS build does not work (@2shady4u is investigating this)

Testing

• test finished branch on WINDOWS (including demo project)
• test finished branch on MACOS (including demo project)
• will be done in seperate PR: test finished branch on LINUX (including demo project)
• will be done in seperate PR: test finished branch on ANDROID (including demo project)
• will be done in seperate PR: test finished branch on iOS (including demo project)

Additional notes

To work on this PR update the godot-cpp submodule to latest master:

git submodule update --init --recursive

then build this project, e.g.:

# 32bit for Windows
scons target=editor platform=windows arch=x86_32 generate_bindings=yes
# 64bit for Windows
scons target=editor platform=windows arch=x86_64 generate_bindings=yes

[piiertho]

Hello @bitbrain !
Thanks for starting this big work.
In Godot 4 classes have been renamed for consistency purpose.
ˋTransformis nowTransform3D, but this should not change how we manage between 2D and 3D, we already have distinct methods for this. Spatialhas been renamedNode3D, for consistency with Node2D`.

Edit: maybe this would be a good idea to split 2D and 3D for fmod too, I think this can be done fast using a CRTP. What do you think about this idea @CedNaru ?

[bitbrain]

Both FIND_AND_CHECK and ERROR_CHECK are currently failing (these macros resolve into invalid syntax) - need to figure out what is causing it.

I also added additional TODOs. For example, the SConstruct file does not seem to work correctly with the new godot-cpp version - it simply fails to discover the includes correctly:

cl /Fosrc\godot_fmod.obj /c src\godot_fmod.cpp /TP /nologo /O2 /EHsc /DNDEBUG /MD /IC:\Users\Miguel\git\fmod-project\godot-cpp\godot-headers /IC:\Users\Miguel\git\fmod-project\godot-cpp\include /IC:\Users\Miguel\git\fmod-project\godot-cpp\include\core /IC:\Users\Miguel\git\fmod-project\godot-cpp\include\gen /IC:\Users\Miguel\git\fmod-project\libs\fmod\windows\core\inc /IC:\Users\Miguel\git\fmod-project\libs\fmod\windows\studio\inc
godot_fmod.cpp
C:\Users\Miguel\git\fmod-project\fmod-gdnative\src\godot_fmod.h(4): fatal error C1083: Cannot open include file: 'godot.hpp': No such file or directory
scons: *** [src\godot_fmod.obj] Error 2
scons: building terminated because of errors.

It doesn't seem to check for the correct godot-cpp\include\godot_cpp path where this file exists:

[bitbrain]

Tested this on both Windows and MacOS without issues (apart from the signal issue @CedNaru is looking into)

[bitbrain]

@piiertho absolute legend!!!!