Removing FmodEditorExportPluginProxy class #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FmodEditorExportPluginProxy was a workaround for a bug that existed in a previous version of Godot. That bug is now fixed, so there is no further need to have this class that inherits from the base FmodEditorExportPlugin.
This change simply deletes the file containing the inherited Proxy object, and replaces it's initial instantiation in FmodPlugin.gd with the base class.
I also removed it from the global_script_class_cash.cfg; I don't know if Godot checks items in the global script class cache to see if they still exist, but if not, this should cover it.
Picture below illustrates recognition of FmodEditorExportPlugin when assigned as export_plugin, where before it would be colored like the definition of dummy_plugin, which is unrecognized due to a purposeful typo to show the difference.
Tested a default scene with nothing going on in it other than a Node3D with an Emitter and Listener child, and no errors occur.