Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement getRgbppSpvProof for OfflineBtcAssetsDataSource #298

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

fghdotio
Copy link
Contributor

This feature allows users to provide SPV proofs when initializing the OfflineBtcAssetsDataSource, serving as a backup method for the BtcAssetsApi's cron job to unlock BTC time locked cells. This basically completes the core functionality of the OfflineBtcAssetsDataSource.

@duanyytop
Copy link
Collaborator

duanyytop commented Jan 21, 2025

Please provide the CKB transaction hash to unlock the example's BTC time cell and run npx changeset to provide changeset like: https://github.com/utxostack/rgbpp-sdk/pull/297/files#diff-28110420e90e7b83c6a0b8b5112495f36a42bb30354d2f9d83b3578394aeb6e8R1

@fghdotio
Copy link
Contributor Author

In this CKB transaction (link), an sUDT token, which was locked by a BTC time lock and could not be unlocked by the btc-assets-api's cron job, was unlocked using the provided example code.

@duanyytop
Copy link
Collaborator

In this CKB transaction (link), an sUDT token, which was locked by a BTC time lock and could not be unlocked by the btc-assets-api's cron job, was unlocked using the provided example code.

got it. The rgbpp-sdk and btc-assets-api only support xUDT and xUDT-compatible assets, so the sUDT assets will not be unlocked by btc-assets-api.

duanyytop
duanyytop previously approved these changes Jan 21, 2025
@fghdotio
Copy link
Contributor Author

Fixed offline examples in this commit c4bd798.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants