Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chmod: add support for the deref and links options #7025

Merged
merged 7 commits into from
Jan 11, 2025
Merged

chmod: add support for the deref and links options #7025

merged 7 commits into from
Jan 11, 2025

Conversation

sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Dec 29, 2024 •
edited
Loading

Closes: #7023

@sylvestre sylvestre force-pushed the chmod-L-2 branch 2 times, most recently from 9c02aba to 05d59bf Compare December 30, 2024 10:29
@sylvestre
Copy link
Contributor Author

@jfinkels what I was mentioning yesterday

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/chmod/symlinks is no longer failing!

@sylvestre sylvestre force-pushed the chmod-L-2 branch 6 times, most recently from d06f8ea to d93b699 Compare December 30, 2024 12:12
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/chmod/symlinks is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre marked this pull request as ready for review December 30, 2024 12:55
@sylvestre
Copy link
Contributor Author

it is the last failing test for chmod:
image

I also noticed this problem upstream:
https://lists.gnu.org/archive/html/coreutils/2024-12/msg00042.html

@sylvestre
Copy link
Contributor Author

I will simplify the tests later. I think they could be merged

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/chmod/symlinks is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/chmod/symlinks is no longer failing!
Congrats! The gnu test tests/seq/seq is no longer failing!

@sylvestre sylvestre requested a review from cakebaker January 2, 2025 10:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/chmod/symlinks is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor Author

@cakebaker ping?
It is blocking the next release :)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/chmod/symlinks is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre mentioned this pull request Jan 11, 2025
Merged
@cakebaker
Copy link
Contributor

@sylvestre ok, I will have a look at it :)

cakebaker
cakebaker reviewed Jan 11, 2025
View reviewed changes
tests/by-util/test_chmod.rs Outdated
set_permissions(at.plus(target), Permissions::from_mode(0o664)).unwrap();
at.symlink_file(target, symlink);

// Use --no-dereference: should modify the symlink itself
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is a bit misleading because the permissions of the symlink itself remain the same.

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/chmod/symlinks is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/chmod/symlinks is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit 045a75e into uutils:main Jan 11, 2025
65 checks passed
@cakebaker
Copy link
Contributor

Congrats! The gnu test tests/chmod/symlinks is no longer failing!

Great, good job :)

@sylvestre sylvestre deleted the chmod-L-2 branch January 12, 2025 00:44
sylvestre added a commit that referenced this pull request Jan 12, 2025
@sylvestre
remove test t tests/chmod/symlinks from the list
b38af88 
#7025
@sylvestre sylvestre mentioned this pull request Jan 12, 2025
Merged
sylvestre added a commit that referenced this pull request Jan 12, 2025
@sylvestre
remove test t tests/chmod/symlinks from the list (#7125)
c643ba1 
#7025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker approved these changes

@jfinkels jfinkels Awaiting requested review from jfinkels

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chmod: -L option fails to traverse symlinks
2 participants
@sylvestre @cakebaker