build: Add infrastructure to setup an account for the first time #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-104--pdc-ssphere.netlify.app |
lsetiawan
reviewed
Sep 26, 2024
lsetiawan
reviewed
Sep 26, 2024
lsetiawan
reviewed
Sep 26, 2024
lsetiawan
reviewed
Sep 26, 2024
lsetiawan
reviewed
Sep 26, 2024
There was a problem hiding this comment.
I added some suggested changes above. Not sure if the ops group name was intentionally hardcoded in some places. I think otherwise, everything seem reasonable. Definitely looks like a lot of work has been put in! Nice job in figuring all of this out. It's quite valuable and the structure looks good. 👍🏽 I'll hold on approving for a bit until my questions are answered. Thanks.
Co-authored-by: Don Setiawan <landungs@uw.edu>
Co-authored-by: Don Setiawan <landungs@uw.edu>
Co-authored-by: Don Setiawan <landungs@uw.edu>
Not intentionally! Added the variable later on and I guess I didn't fully clean up all the hardcoded references! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the following
accountandinfrastructure, ops roles split out of the server module and into their own module)This ended up being a monster, I'm really sorry about that!