-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: setup CI and framework for unit tests #129
Conversation
@@ -0,0 +1,32 @@ | |||
name: Frontend CI | |||
|
|||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make this workflow to run only for changes within src/support_sphere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, probably should run on push to main as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
authService = AuthService(); | ||
}); | ||
|
||
group('AuthService', () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is group
vs setUp
? Could you provide a little bit of description for these two? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* test: setup CI and framework for unit tests * style: update dummy test * test: authService signUp codes tests * test: add build_runner for mocking test classes in CI testing * ci: run workflow only for frontend changes * docs: add description for test group and setup
* test: setup CI and framework for unit tests * style: update dummy test * test: authService signUp codes tests * test: add build_runner for mocking test classes in CI testing * ci: run workflow only for frontend changes * docs: add description for test group and setup
* Update the function to be more DRY * test: setup CI and framework for unit tests (#129) * test: setup CI and framework for unit tests * style: update dummy test * test: authService signUp codes tests * test: add build_runner for mocking test classes in CI testing * ci: run workflow only for frontend changes * docs: add description for test group and setup * Pass the class instead of cubit --------- Co-authored-by: Parvati Jayakumar <parvati@Parvatis-MacBook-Pro.local> Co-authored-by: anujsinha3 <anuj3@uw.edu>
* Updated SignUp Button to remain grey till all the entries are valid * Updated Login Button to remain grey till all the entries are valid * test: setup CI and framework for unit tests (#129) * test: setup CI and framework for unit tests * style: update dummy test * test: authService signUp codes tests * test: add build_runner for mocking test classes in CI testing * ci: run workflow only for frontend changes * docs: add description for test group and setup * Move isAllFieldsFilled logic to LoginCubit * Move isAllFieldsFilled logic to SignupCubit * Update the button to activate only when it is valid and have all the fields filled in * refactor: Make hardcoded string for routes and app roles to constants (#148) * feat: Add data analysis framework (#153) * Fix isValid bug * Split field and status listeners in Signup/Login forms * Build both password/confirm password again when either of them change * Show Validation Error while filling out the fields * Update validateValue function/function call to make it more dry * Have Signup/Login button enable feature in the state rather than as a function * Have isAllFields as a state variable and update the way Login/Signup button enable state is called * Have isSignupButtonEnabled and isLoginButtonEnabled in cubit to avoid the flickering issue --------- Co-authored-by: Parvati Jayakumar <parvati@Parvatis-MacBook-Pro.local> Co-authored-by: anujsinha3 <anuj3@uw.edu> Co-authored-by: Don Setiawan <landungs@uw.edu>
#92