Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: setup CI and framework for unit tests #129

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

anujsinha3
Copy link
Contributor

@anujsinha3 anujsinha3 commented Oct 16, 2024

#92

  • add frontend CI pipeline and unit test framework for flutter.
  • added unit tests to validate signupcodes
  • added build_runner step in CI pipeline for testing using mock classes

@anujsinha3 anujsinha3 self-assigned this Oct 17, 2024
@@ -0,0 +1,32 @@
name: Frontend CI

on:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this workflow to run only for changes within src/support_sphere

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, probably should run on push to main as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

authService = AuthService();
});

group('AuthService', () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is group vs setUp? Could you provide a little bit of description for these two? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Member

@lsetiawan lsetiawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsetiawan lsetiawan merged commit d70799a into uw-ssec:main Oct 18, 2024
2 checks passed
parvatijay2901 pushed a commit to parvatijay2901/post-disaster-comms that referenced this pull request Oct 22, 2024
* test: setup CI and framework for unit tests

* style: update dummy test

* test: authService signUp codes tests

* test: add build_runner for mocking test classes in CI testing

* ci: run workflow only for frontend changes

* docs: add description for test group and setup
parvatijay2901 pushed a commit to parvatijay2901/post-disaster-comms that referenced this pull request Oct 22, 2024
* test: setup CI and framework for unit tests

* style: update dummy test

* test: authService signUp codes tests

* test: add build_runner for mocking test classes in CI testing

* ci: run workflow only for frontend changes

* docs: add description for test group and setup
lsetiawan pushed a commit that referenced this pull request Oct 23, 2024
* Update the  function to be more DRY

* test: setup CI and framework for unit tests (#129)

* test: setup CI and framework for unit tests

* style: update dummy test

* test: authService signUp codes tests

* test: add build_runner for mocking test classes in CI testing

* ci: run workflow only for frontend changes

* docs: add description for test group and setup

* Pass the class instead of cubit

---------

Co-authored-by: Parvati Jayakumar <parvati@Parvatis-MacBook-Pro.local>
Co-authored-by: anujsinha3 <anuj3@uw.edu>
lsetiawan added a commit that referenced this pull request Oct 29, 2024
* Updated SignUp Button to remain grey till all the entries are valid

* Updated Login  Button to remain grey till all the entries are valid

* test: setup CI and framework for unit tests (#129)

* test: setup CI and framework for unit tests

* style: update dummy test

* test: authService signUp codes tests

* test: add build_runner for mocking test classes in CI testing

* ci: run workflow only for frontend changes

* docs: add description for test group and setup

* Move isAllFieldsFilled logic to LoginCubit

* Move isAllFieldsFilled logic to SignupCubit

* Update the button to activate only when it is valid and have all the fields filled in

* refactor: Make hardcoded string for routes and app roles to constants (#148)

* feat: Add data analysis framework (#153)

* Fix isValid bug

* Split field and status listeners in Signup/Login forms

* Build both password/confirm password again when either of them change

* Show Validation Error while filling out the fields

* Update validateValue function/function call to make it more dry

* Have Signup/Login button enable feature in the state rather than as a function

* Have isAllFields as a state variable and update the way Login/Signup button enable state is called

* Have isSignupButtonEnabled and isLoginButtonEnabled in cubit to avoid the flickering issue

---------

Co-authored-by: Parvati Jayakumar <parvati@Parvatis-MacBook-Pro.local>
Co-authored-by: anujsinha3 <anuj3@uw.edu>
Co-authored-by: Don Setiawan <landungs@uw.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants