Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop Schedule Page UI Layout #94

Merged
merged 8 commits into from
Oct 3, 2024
Merged

Develop Schedule Page UI Layout #94

merged 8 commits into from
Oct 3, 2024

Conversation

Danie1T
Copy link
Contributor

@Danie1T Danie1T commented Jul 14, 2024

Notion ticket link

Develop Schedule Page UI Layout

Implementation description

  • Added layout, hardcoded values atm since we don't have ability to grab all rooms

Steps to test

  1. NEED TO CHECK IF LAYOUT IS FINE BY MOVING SIDEBAR FROM PRIVATEROUTE TO COMPONENT PAGE

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Danie1T Danie1T requested a review from ya5er July 14, 2024 04:11
@jeessh jeessh merged commit d012eb2 into dev Oct 3, 2024
1 check passed
@jeessh jeessh deleted the daniel/schedule-page-ui branch October 3, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants